Adding exception picker to license picker form#1118
Conversation
❌ Deploy Preview for blissful-goodall-fa23f6 failed.
|
|
Thanks for adding SPDX exception support. A few things that came up to consider before merging: Data corruption: space sentinel in exception initialization Clicking "+ WITH" calls Suggestion: use Shallow copy + nested mutation in updateException
Clearing a license doesn't clear the The new code clears Minor items:
|
|
@ashleywolf Thank you for the feedback! ❤️ I'll start looking at each of the issues mentioned. I didn't even think to check the |
…r fallback - Replace space sentinel with 'pending' marker for exception picker open state - Fix shallow copy mutations in updateException/updateLicense using lodash/set - Clear both 'plus' and 'exception' flags when license is cleared - Fix spdxExceptions.sort() mutating imported module array - Add key prop to SpdxExceptionPicker for controlled remount - Allow custom exception identifiers (ScanCode LicenseDB support) - Handle parser returning noassertion for valid non-NOASSERTION expressions - Exclude 'pending' sentinel from toString() serialization - Add index.css.map to .gitignore and remove from tracking - Restore FileList tree expansion (expandedRowKeys) - Fix breadcrumb className formatting
This allows UI users to submit curations with SPDX exceptions (WITH). More fixes to correct the table layout.
Test PRs submitted:
New WITH button:

New exception picker after clicking button:

Exception picker list:

Table layout fix:
